goc_daniel/b2b
2
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

no-vat-customers #71

Merged
dudzic_wiktor merged 8 commits from no-vat-customers into main 2026-04-15 11:32:14 +00:00
Conversation 1 Commits 8 Files Changed 7 +134 -70
dudzic_wiktor commented 2026-04-15 10:57:12 +00:00
Collaborator
Copy Link
No description provided.
dudzic_wiktor added 5 commits 2026-04-15 10:57:13 +00:00
feat: add no vat property to customers f55d59a0fd
Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into no-vat-customers 31a2744131
Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into no-vat-customers 8e063978a8
Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into no-vat-customers e31ecda582
feat: add no vat customers logic 1bf706dcd0
dudzic_wiktor requested review from goc_daniel 2026-04-15 10:57:13 +00:00
dudzic_wiktor added 1 commit 2026-04-15 10:57:18 +00:00
Merge branch 'main' into no-vat-customers cc570cc6a8
dudzic_wiktor scheduled this pull request to auto merge when all checks succeed 2026-04-15 10:57:26 +00:00
dudzic_wiktor added 2 commits 2026-04-15 10:58:47 +00:00
feat: add no vat customers logic e9af4bf311
Merge branch 'no-vat-customers' of ssh://git.ma-al.com:8822/goc_daniel/b2b into no-vat-customers 6efb39edf7
goc_daniel approved these changes 2026-04-15 11:32:12 +00:00
goc_daniel left a comment
Owner
Copy Link

looks good (I only glanced over the logic changes in calculating prices)

looks good (I only glanced over the logic changes in calculating prices)
i18n/migrations/20260302163122_create_tables.sql
@@ -114,2 +114,3 @@
updated_at DATETIME(6) NULL,
deleted_at DATETIME(6) NULL
deleted_at DATETIME(6) NULL,
is_no_vat TINYINT(1) NULL DEFAULT 0
goc_daniel commented 2026-04-15 11:27:34 +00:00
Owner
Copy Link

if it has default value, then perhaps make it NOT NULL?

if it has default value, then perhaps make it NOT NULL?
dudzic_wiktor commented 2026-04-15 11:34:07 +00:00
Author
Collaborator
Copy Link

that's true, it makes more sense to set it to NOT NULL. the PR already auto-merged so I'll make the change in next unrelated PR

that's true, it makes more sense to set it to NOT NULL. the PR already auto-merged so I'll make the change in next unrelated PR
dudzic_wiktor merged commit 9a90de3f11 into main 2026-04-15 11:32:14 +00:00
dudzic_wiktor deleted branch no-vat-customers 2026-04-15 11:32:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
goc_daniel
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dudzic_wiktor goc_marek yakovenko_arina yakovenko_valeriia goc_daniel
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: goc_daniel/b2b#71
Delete Branch "no-vat-customers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?