goc_daniel/b2b
2
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

expand orders #75

Merged
goc_daniel merged 3 commits from expand_orders into main 2026-04-16 14:25:59 +00:00
Conversation 1 Commits 3 Files Changed 10 +74 -10
goc_daniel commented 2026-04-16 09:49:08 +00:00
Owner
Copy Link
  • bugfix in auth.go
  • added fields BasePrice, TaxIncl, TaxExcl, UpdatedAt, CreatedAt
- bugfix in auth.go - added fields BasePrice, TaxIncl, TaxExcl, UpdatedAt, CreatedAt
goc_daniel added 1 commit 2026-04-16 09:49:08 +00:00
expand orders f435a8839b
goc_daniel requested review from dudzic_wiktor 2026-04-16 13:00:19 +00:00
goc_daniel removed review request for dudzic_wiktor 2026-04-16 13:00:46 +00:00
goc_daniel added 2 commits 2026-04-16 13:02:42 +00:00
Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into expand_orders 7995177fe1
merge and small bugfix d73dad8975
goc_daniel requested review from dudzic_wiktor 2026-04-16 13:03:38 +00:00
dudzic_wiktor requested changes 2026-04-16 13:22:21 +00:00
app/repos/ordersRepo/ordersRepo.go
@@ -106,3 +115,3 @@
Table("b2b_customer_orders").
Where("order_id = ?", order_id).
Update("status", status).
Updates(map[string]interface{}{
dudzic_wiktor commented 2026-04-16 13:07:24 +00:00
Collaborator
Copy Link

this code is fine but just letting you know that when you use DB.Model() instead of DB.Table the updated_at columns is being updated by gorm automatically

this code is fine but just letting you know that when you use DB.Model() instead of DB.Table the updated_at columns is being updated by gorm automatically
goc_daniel marked this conversation as resolved
app/service/authService/auth.go
@@ -130,6 +130,7 @@ func (s *AuthService) Login(req *model.LoginRequest) (*model.AuthResponse, strin
user.LangID = *req.LangID
}
user.Country = nil
dudzic_wiktor commented 2026-04-16 13:21:21 +00:00
Collaborator
Copy Link

db shouldn't be called in the service and updating logic should be in single place in repo. that way we don't have to rely on remembering to nullify associated models like country.

Best approach would be to build a Customer model out of a DTO for this operation for the sake of safety.
But the customer struct is small enough that nullifying Country and Role would be sufficient for now.

db shouldn't be called in the service and updating logic should be in single place in repo. that way we don't have to rely on remembering to nullify associated models like country. Best approach would be to build a Customer model out of a DTO for this operation for the sake of safety. But the customer struct is small enough that nullifying Country and Role would be sufficient for now.
goc_daniel commented 2026-04-16 14:25:19 +00:00
Author
Owner
Copy Link

yeah, it's old code, and it's coauthored by me and Marek. Let's leave things as they are (and hopefully not change Customer struct anymore)

yeah, it's old code, and it's coauthored by me and Marek. Let's leave things as they are (and hopefully not change Customer struct anymore)
goc_daniel marked this conversation as resolved
goc_daniel merged commit 931840c243 into main 2026-04-16 14:25:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
dudzic_wiktor
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dudzic_wiktor goc_marek yakovenko_arina yakovenko_valeriia goc_daniel
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: goc_daniel/b2b#75
Delete Branch "expand_orders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?