goc_daniel
  • Joined on 2026-02-22
goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

Is there a reason we're not using model.Product here? There's already so many different product types I feel like it's gonna cause a problem down the line. Alternatively we can delete model.Product, since it really is just a copy of ps_product database type. (The latter sounds like a good thing to do)

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

this is doing nothing

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

also doing nothing

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

there is 1 hardcoded here (for quantity)

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

idk if we want to keep a close eye on the returned errors? Because most files return responseErrors.ErrInvalidBody when localeExtractor fails. Similarly, when attribute can not be parsed, most handlers return esponseErrors.ErrBadAttribute.

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

Also 1 hardcoded here

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:02:10 +00:00
product-procedures

This function is not used anywhere

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 10:01:20 +00:00
product-procedures

Okay, so I looked at most of it, basically excluding specificPriceRepo.go and sql procedures.

goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 08:38:30 +00:00
product-procedures

What is the stuff.sql file? Looks like some leftovers from testing

goc_daniel opened issue goc_daniel/b2b#60 2026-04-13 08:34:20 +00:00
slugify functionality repeated
goc_daniel commented on pull request goc_daniel/b2b#59 2026-04-13 08:31:17 +00:00
product-procedures

There's additional issue with indexes in create_tables. We have:

CREATE INDEX idx_bsp_customer ON b2b_specific_price_customer (b2b_specific_price_id, b2b_id_customer);

but b2b_specific_pric…

goc_daniel pushed to orders at goc_daniel/b2b 2026-04-13 07:21:36 +00:00
1f6d5ecb72 go routine and removing cart
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 13:17:33 +00:00
d4d55e2757 send email when creating new order
goc_daniel created pull request goc_daniel/b2b#58 2026-04-10 12:58:07 +00:00
orders
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 12:57:28 +00:00
80d26bba12 GET -> POST
goc_daniel closed issue goc_daniel/b2b#56 2026-04-10 12:53:53 +00:00
favorites
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 12:53:44 +00:00
33e9d016e9 basic orders are ready
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 11:25:04 +00:00
a03a2b461f small fix
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 11:23:55 +00:00
134bc4ea53 code ready, time for testing...
goc_daniel pushed to orders at goc_daniel/b2b 2026-04-10 10:17:57 +00:00
8595969c6e Find is done