goc_daniel
0 Followers · 0 Following
  • Joined on 2026-02-22
Repositories
1
 Projects
1
 Packages Code Public Activity Starred Repositories
goc_daniel closed issue goc_daniel/b2b#73 2026-04-16 14:26:10 +00:00
Expand orders table
goc_daniel pushed to main at goc_daniel/b2b 2026-04-16 14:26:00 +00:00
931840c243 Merge pull request 'expand orders' (#75) from expand_orders into main
d73dad8975 merge and small bugfix
7995177fe1 Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into expand_orders
f435a8839b expand orders
Compare 4 commits »
goc_daniel merged pull request goc_daniel/b2b#75 2026-04-16 14:25:59 +00:00
expand orders
goc_daniel commented on pull request goc_daniel/b2b#75 2026-04-16 14:25:19 +00:00
expand orders

yeah, it's old code, and it's coauthored by me and Marek. Let's leave things as they are (and hopefully not change Customer struct anymore)

goc_daniel pushed to expand_orders at goc_daniel/b2b 2026-04-16 13:02:42 +00:00
d73dad8975 merge and small bugfix
7995177fe1 Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into expand_orders
70e0e23ace Merge pull request 'feat: implement logger' (#74) from logger into main
9961d90fa7 feat: implement logger
Compare 4 commits »
goc_daniel approved goc_daniel/b2b#74 2026-04-16 12:59:58 +00:00
feat: implement logger
goc_daniel created pull request goc_daniel/b2b#75 2026-04-16 09:49:08 +00:00
expand orders
goc_daniel created branch expand_orders in goc_daniel/b2b 2026-04-16 09:48:03 +00:00
goc_daniel pushed to expand_orders at goc_daniel/b2b 2026-04-16 09:48:03 +00:00
f435a8839b expand orders
goc_daniel commented on pull request goc_daniel/b2b#74 2026-04-16 09:12:54 +00:00
feat: implement logger

I feel like it belongs to utils.

goc_daniel commented on pull request goc_daniel/b2b#74 2026-04-16 09:12:54 +00:00
feat: implement logger

Possibly it's own config, but no need to in my opinion

goc_daniel commented on pull request goc_daniel/b2b#74 2026-04-16 09:12:54 +00:00
feat: implement logger

maybe blue? Like road signs. Probably deep blue. Should definitely be more contrasting with terminal background than LevelDebug, but less than LevelWarn and LevelError.

goc_daniel commented on pull request goc_daniel/b2b#74 2026-04-16 09:12:54 +00:00
feat: implement logger

this is bad. Errors can vary here, from database error to wrong credentials, and I don't think levelError is appropriate. This logger will have to be pushed down to service level.

goc_daniel suggested changes for goc_daniel/b2b#74 2026-04-16 09:12:54 +00:00
feat: implement logger

Okay, I won't be going over the exact instances of where logger is used, that's a big TODO. Otherwise, looks good (with these 2 comments)

goc_daniel opened issue goc_daniel/b2b#73 2026-04-15 11:53:10 +00:00
Expand orders table
goc_daniel pushed to main at goc_daniel/b2b 2026-04-15 11:32:44 +00:00
7bce04e05a Merge pull request 'is_oem' (#72) from is_oem into main
754bf2fe01 Merge branch 'main' of ssh://git.ma-al.com:8822/goc_daniel/b2b into is_oem
2ca07f03ce expanded by is_oem
Compare 3 commits »
goc_daniel merged pull request goc_daniel/b2b#72 2026-04-15 11:32:43 +00:00
is_oem
goc_daniel commented on pull request goc_daniel/b2b#71 2026-04-15 11:32:12 +00:00
no-vat-customers

if it has default value, then perhaps make it NOT NULL?

goc_daniel approved goc_daniel/b2b#71 2026-04-15 11:32:12 +00:00
no-vat-customers

looks good (I only glanced over the logic changes in calculating prices)

goc_daniel created pull request goc_daniel/b2b#72 2026-04-15 11:22:07 +00:00
is_oem